Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samtools idxstats component #32

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

emmarousseau
Copy link
Collaborator

Description

Samtools idxstats

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@emmarousseau emmarousseau marked this pull request as draft March 29, 2024 14:49
@emmarousseau emmarousseau marked this pull request as ready for review March 29, 2024 15:27
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left some minor comments / suggestions for you to review :)

src/samtools/idxstats/config.vsh.yaml Outdated Show resolved Hide resolved
src/samtools/idxstats/config.vsh.yaml Outdated Show resolved Hide resolved
src/samtools/idxstats/help.txt Outdated Show resolved Hide resolved
src/samtools/idxstats/config.vsh.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/samtools/samtools_idxstats/test.sh Outdated Show resolved Hide resolved
@rcannood
Copy link
Contributor

rcannood commented Apr 3, 2024

Overlooked this minor detail at first glance

Add a slash to path to test data

Co-authored-by: Robrecht Cannoodt <[email protected]>
@rcannood rcannood merged commit 1200bc3 into viash-hub:main Apr 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants